Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.11] 🤖 Sync from open-cluster-management-io/config-policy-controller: #273 #949

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #947

/assign mprahl

When a help message is provided such as suggesting to set
recreateOption, it was getting overwritten during the next evaluation
based on the cached evaluation result.

Relates:
https://issues.redhat.com/browse/ACM-12631

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 558c6a7b20b9628723712f3f1891dfc84e14e5a2)
Copy link
Contributor

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for 2.11.1

Copy link

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 8, 2024
Copy link

sonarcloud bot commented Jul 8, 2024

@mprahl
Copy link
Contributor

mprahl commented Jul 16, 2024

/unhold should be in the clear now

@mprahl mprahl merged commit 93f7a60 into stolostron:release-2.11 Jul 24, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants