Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ACM-12426 PatternFly 5 adoption #3809

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

KevinFCormier
Copy link
Contributor

@KevinFCormier KevinFCormier commented Aug 28, 2024

https://issues.redhat.com/browse/ACM-12426

  • Updates patternfly packages to version 5 or compatible version
  • Updates codebase with automated codemod and class name changes
  • Replaces temporarily copied SearchInput implementation with import
  • Wraps icons in Icon component to specify size and status (for standard colors)
  • Fixes all event handlers (event is now always the first argument for event callbacks on PF components)
  • Introduces AcmHelperText component that sets up form helper text using the new FormHelperText component (attributes for helper text and validated state on FormGroup have been removed)
  • Numerous other small updates for PF component API changes
  • Styling fixes and bug workarounds
  • Updates monaco packages

Copy link

openshift-ci bot commented Aug 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KevinFCormier KevinFCormier force-pushed the pf5-adoption branch 2 times, most recently from 09af16e to 5c1ea16 Compare September 10, 2024 18:09
@KevinFCormier KevinFCormier changed the title ACM-12426 PatternFly 5 adoption WIP ACM-12426 PatternFly 5 adoption Sep 10, 2024
@KevinFCormier KevinFCormier marked this pull request as ready for review September 10, 2024 18:31
@KevinFCormier KevinFCormier force-pushed the pf5-adoption branch 2 times, most recently from 91b698d to 64a6dc4 Compare September 10, 2024 19:23
@KevinFCormier KevinFCormier force-pushed the pf5-adoption branch 2 times, most recently from e43e8a0 to c084f64 Compare October 31, 2024 20:34
@KevinFCormier KevinFCormier force-pushed the pf5-adoption branch 3 times, most recently from a83f180 to 03a8443 Compare November 13, 2024 21:41
@KevinFCormier KevinFCormier force-pushed the pf5-adoption branch 2 times, most recently from b97b068 to 1a25ac1 Compare November 18, 2024 14:04
npm run prettier:fix

Signed-off-by: Kevin Cormier <[email protected]>
…x,js,html,css src

npm run prettier:fix

Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
npm i [email protected] [email protected] @monaco-editor/[email protected]
npm i -D monaco-editor-webpack-plugin@7

Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
npm run jest:update-snapshot

Signed-off-by: Kevin Cormier <[email protected]>
Copy link

openshift-ci bot commented Nov 27, 2024

@KevinFCormier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 243ab8f link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants