Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-13003-Fast-cluster-page-load #4110

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jeswanke
Copy link
Contributor

@jeswanke jeswanke commented Nov 25, 2024

  1. environment label MOCK_CLUSTERS="number" in order to mock that many clusters and
    3 policies and
    44 system apps for each cluster
  2. that context error you found was caused by trying to use PluginContext in acm (mce only it looks like)
  3. there's a new LoadStatusProvider that any plugin can use that tells at what stage LoadData is:
    loadStarted --> the first packet has been received, if the data for that page is in the first packet it can start displaying
    loadCompleted --> the load of all data is done (the old loaded context value)

the first packets are these:
case 'ManagedCluster':
case 'HostedCluster':
case 'ClusterDeployment':
case 'Policy':
case 'PolicySet':
case 'AgentClusterInstall':
case 'ManagedClusterInfo':
case 'ManagedClusterAddOn':
case 'Search':
case 'Secret':

Signed-off-by: John Swanke [email protected]

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
@jeswanke
Copy link
Contributor Author

jeswanke commented Dec 1, 2024

/test unit-tests-sonarcloud

1 similar comment
@jeswanke
Copy link
Contributor Author

jeswanke commented Dec 1, 2024

/test unit-tests-sonarcloud

Copy link

openshift-ci bot commented Dec 1, 2024

@jeswanke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 3625690 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant