Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-16021 Refactor multi-namespace self access checks [release-2.10] #4113

Open
wants to merge 1 commit into
base: release-2.10
Choose a base branch
from

Conversation

KevinFCormier
Copy link
Contributor

@KevinFCormier KevinFCormier commented Nov 28, 2024

Previously, when a user could see a large number of namespaces, UI buttons could sometimes flap between enabled and disabled. This was because a failed network connection counted as no access. This PR makes a few improvements:

  • Self access checks across multiple namespaces are batched to avoid overwhelming the browser
  • Once a button becomes enabled, it will not become disabled until we confirm that there is no access in any namespace
  • Logic is centralized in a reusable hook to reduce code duplication for each button that uses this RBAC check

ACM-16021

Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KevinFCormier
Copy link
Contributor Author

/test unit-tests-sonarcloud

@KevinFCormier KevinFCormier changed the base branch from release-2.10 to backplane-2.5 November 29, 2024 14:06
@KevinFCormier KevinFCormier changed the base branch from backplane-2.5 to release-2.10 November 29, 2024 15:02
@KevinFCormier
Copy link
Contributor Author

/test unit-tests-sonarcloud

1 similar comment
@KevinFCormier
Copy link
Contributor Author

/test unit-tests-sonarcloud

@KevinFCormier KevinFCormier changed the title Refactor multi-namespace self access checks [release-2.10] ACM-16021 Refactor multi-namespace self access checks [release-2.10] Nov 29, 2024
Copy link

sonarcloud bot commented Nov 29, 2024

@KevinFCormier
Copy link
Contributor Author

/cc @jeswanke

@openshift-ci openshift-ci bot requested a review from jeswanke November 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant