Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller to watch external-kubeconfig-secret #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philipwu08
Copy link
Contributor

Description of the change(s):

  • Add a controller to watch the external-managed-kubeconfig secret for deletion. If it is deleted, add an annotation to the HC to trigger a reconcile of the HC, which would recreate the secret.

Why do we need this PR:

  • If the external-managed-kubeconfig is deleted today, it requires manual steps by the user to recreate it.

Issue reference:

Test API/Unit - Success

ok  	github.com/stolostron/hypershift-addon-operator/pkg/agent	19.835s	coverage: 71.3% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/install	277.243s	coverage: 87.0% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/manager	1.871s	coverage: 56.2% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/metrics	0.609s	coverage: 100.0% of statements

Signed-off-by: Philip Wu [email protected]

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipwu08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

@philipwu08: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonar 5998f72 link true /test sonar

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants