Deep copy by default #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The options passed to `NewObjectCache` were not actually being copied into the returned object cache. Signed-off-by: Justin Kulikauskas <[email protected]>
dhaiducek
reviewed
Apr 30, 2024
Not DeepCopying can save some resources in some situations, but is also a common way to introduce hard-to-find bugs, since items in the cache can then mutate unexpectedly. This library now follows the pattern from controller-runtime, which does a DeepCopy by default, which can be disabled with an option when creating the client. Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
deep-copy-by-default
branch
from
dfc2b14 to
2d95c84
Compare
|
dhaiducek
approved these changes
Apr 30, 2024
| @@ -87,6 +90,7 @@ func NewObjectCache(discoveryClient *discovery.DiscoveryClient, options ObjectCa | |||
| cache: &sync.Map{}, | |||
| gvkToGVRCache: &sync.Map{}, | |||
| discoveryClient: discoveryClient, | |||
| options: options, | |||
There was a problem hiding this comment.
Question: Was this just missed (or unnecessary) previously?
There was a problem hiding this comment.
I think it was just missed. The other options aren't tested (and I think that's ok; they'd be annoying to test for a low payoff).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not DeepCopying can save some resources in some situations, but is also a common way to introduce hard-to-find bugs, since items in the cache can then mutate unexpectedly. This library now follows the pattern from controller-runtime, which does a DeepCopy by default, which can be disabled with an option when creating the client.