fix e2e test issues when sno leader election enabled #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
haoqing0110
force-pushed
the
br_fix-e2e-sno
branch
6 times, most recently
from
761d9fc to
4914a0b
Compare
|
/test e2e |
haoqing0110
force-pushed
the
br_fix-e2e-sno
branch
6 times, most recently
from
0a12a2c to
49e4845
Compare
Signed-off-by: Qing Hao <[email protected]>
haoqing0110
force-pushed
the
br_fix-e2e-sno
branch
from
49e4845 to
442144a
Compare
|
|
/assign @qiujian16 @elgnay @zhiweiyin318 |
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- test/e2e/klusterletconfig_test.go: Evaluated as low risk
Comments skipped due to low confidence (2)
test/e2e/util/util.go:107
- The comment should be updated to reflect the new lease duration: LeaseDurationSeconds: 10.
// LeaseDurationSeconds: 5,
test/e2e/util/util.go:208
- The comment should be updated to reflect the new lease duration: LeaseDurationSeconds: 10.
// LeaseDurationSeconds: 5,
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: open-cluster-management-io/ocm#727
https://issues.redhat.com/browse/ACM-15860
assertManagedClusterManifestWorksAvailableand some cases, add the logic to check manifestwork finalizer, ensure the work agent starts working before each case.CreateHostedManagedClusterWithShortLeaseDuration, increase LeaseDurationSeconds to 10. Since the agent enables leader election, in some cases the agent might start slower than before, increasing the LeaseDurationSeconds to avoid force removal inassertManagedClusterDeletedin AfterEach.restartAgentPods, check the agent leader to ensure the work agent works before the next step.