linting and non-functional fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerd Oberlechner <[email protected]>
| @@ -13,7 +13,7 @@ HELM_VERSION?=v3.14.0 | |||
| helm_gen_dir:=$(dir $(HELM)) | |||
|
|
|||
|
|
|||
| HELM_ARCHOS:=linux-amd64 | |||
| HELM_ARCHOS:=$(shell uname -s | tr '[:upper:]' '[:lower:]')-$(shell uname -m) | |||
There was a problem hiding this comment.
HELM_ARCHOS is used in ensure-helm to install helm, https://get.helm.sh/helm-$(HELM_VERSION)-$(HELM_ARCHOS).tar.gz
In linux env, uname -m is x86_64, but the name of helm tar is helm-v3.14.0-linux-amd64, not helm-v3.14.0-linux-x86_64.tar.gz.
Signed-off-by: Gerd Oberlechner <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geoberle, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4fc9ce3
into
stolostron:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm upgrade --installinstead ofhelm installto allow for repeated make target runs