Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Namespace channel #212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove Namespace channel #212

wants to merge 3 commits into from

Conversation

rokej
Copy link
Contributor

@rokej rokej commented Mar 10, 2022

Signed-off-by: Roke Jung [email protected]

Remove Namespace channel

@rokej
remove Namespace channel
30b23ef 
Signed-off-by: Roke Jung <[email protected]>
@rokej rokej requested a review from xiangjingli March 10, 2022 16:35
@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rokej, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rokej
fix tests
bc24068 
Signed-off-by: Roke Jung <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Mar 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2022

New changes are detected. LGTM label has been removed.

@rokej
fix tests
b619a84 
Signed-off-by: Roke Jung <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjingli xiangjingli Awaiting requested review from xiangjingli

Assignees

@xiangjingli xiangjingli

Labels
approved dco-signoff: yes needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokej @xiangjingli @openshift-merge-robot