Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-3663): format PipelineRun files and upload SAST results #318

Open
wants to merge 2 commits into
base: release-2.10
Choose a base branch
from

Conversation

ccronca
Copy link

@ccronca ccronca commented Aug 16, 2024

This update configures the SAST task to upload SARIF results to quay.io for long-term storage

Please note that this PR was automatically generated and may include unrelated changes due to automatic YAML formatting performed by yq
The YAML files will be indented using 2 spaces, if the YAML file uses indentationless list the automation will try to keep this format

The PR contains two separate commits:

  1. Format YAML files: Ensures consistent indentation and formatting of the YAML files
  2. Upload SAST results: Configures the PipelineRun files to enable uploading SARIF results to quay.io

Separating these changes into two commits simplifies the review process. The first commit focuses on indentation and formatting, while the second commit contains the semantic changes

Related:

Format PipelineRun files with yq for consistent indentation and format

Signed-off-by: ccronca <[email protected]>
Configure the SAST task to upload SARIF results to quay.io for
long-term storage

Signed-off-by: ccronca <[email protected]>
Copy link

openshift-ci bot commented Aug 16, 2024

Hi @ccronca. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xiangjingli
Copy link
Collaborator

/test all

@xiangjingli
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccronca, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2024
@xiangjingli
Copy link
Collaborator

xiangjingli commented Sep 3, 2024

@ccronca @Kyl-Bempah The red Hat Konflux job is pending approval. Here I saw the message

User ccronca is not allowed to trigger CI via pull_request on this repo.

It looks the user ccronca is required to be added as a contributor. I can't see the user in user list here

https://console.redhat.com/application-pipeline/access/workspaces/crt-redhat-acm

Kyl, could you help grant the access to the user?

@Kyl-Bempah
Copy link

You never replied /ok-to-test per the bot's comments and labels on this PR

@xiangjingli
Copy link
Collaborator

/ok-to-test

@xiangjingli
Copy link
Collaborator

@Kyl-Bempah @ccronca Thanks Kyl! The konflux job was triggered after the needs-ok-to-test label was removed.

I saw there is a new error. do you know how to fix it?

Pipeline crt-redhat-acm-tenant/multicluster-operators-channel-acm-210-on-pull-request-ns5lw can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "resolver type bundles\nname = clamav-scan\n": invalid runtime object: strict decoding error: unknown field "spec.volumes[0].emptydir", unknown field "spec.volumes[1].emptydir"

Copy link

sonarcloud bot commented Sep 4, 2024

@Kyl-Bempah
Copy link

You have 3 months worth of migration that need to be reconciled according to these PRS #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants