✨ Switch zap log for global hub manager #1185
Conversation
yanmxa
changed the title
yanmxa
changed the title
yanmxa
force-pushed
the
br_manager
branch
2 times, most recently
from
8baea1a
to
02c0c1b
Compare
Signed-off-by: myan <[email protected]> fix the error Signed-off-by: myan <[email protected]> fix the info Signed-off-by: myan <[email protected]> adjust agent log Signed-off-by: myan <[email protected]> change the transport Signed-off-by: myan <[email protected]> fix the standalone Signed-off-by: myan <[email protected]> add the e2e log Signed-off-by: myan <[email protected]> add the controller runtime log with current zap logger Signed-off-by: myan <[email protected]> format code Signed-off-by: myan <[email protected]> romove the zap parameter from standalone agent Signed-off-by: myan <[email protected]> remove the unnecessary code Signed-off-by: myan <[email protected]> remove the log print Signed-off-by: myan <[email protected]> add manager zap log Signed-off-by: myan <[email protected]> add manager configmap controller Signed-off-by: myan <[email protected]> log remove klog Signed-off-by: myan <[email protected]> remove the go flag Signed-off-by: myan <[email protected]> fix the log Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
|
e2e setup error |
|
/override ci/prow/sonarcloud |
|
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test test-e2e |
|
/override "SonarCloud Code Analysis" |
|
@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: myan <[email protected]>
manager/cmd/main.go
Outdated
| } | ||
|
|
||
| if managerConfig.EnablePprof { | ||
| go utils.StartDefaultPprofServer() | ||
| } | ||
|
|
||
| utils.PrintVersion(setupLog) | ||
| utils.RuntimeInfo() |
| @@ -3,6 +3,9 @@ kind: Secret | |||
| metadata: | |||
| name: {{.TransportConfigSecret}} | |||
| namespace: {{.Namespace}} | |||
| annotations: | |||
| # todo put here or configmap | |||
| za-log-level: {{.LogLevel}} | |||
There was a problem hiding this comment.
shouldn't add in here, remove it now.
Signed-off-by: myan <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/override ci/prow/sonarcloud |
|
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 87cf169
into
stolostron:main
Summary
Related issue(s)
Fixes # https://issues.redhat.com/browse/ACM-13421, #1178
Tests
make unit-tests.make integration-test.make e2e-test-all.