restart when manager and agent cannnot connect to kafka #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ldpliu
force-pushed
the
panic-kaka
branch
3 times, most recently
from
c6023b8 to
ccd1009
Compare
clyang82
requested changes
Dec 3, 2024
|
|
||
| errorCount++ | ||
| if errorCount >= transportFailureThreshold { | ||
| log.Panicf("Thransport producer error > 10 in 5 minutes, error: %v", ev) |
| @@ -212,6 +215,16 @@ func handleProducerEvents(log *zap.SugaredLogger, eventChan chan kafka.Event) { | |||
| log.Warnw("Transport producer client error, ignore it for most cases", "error", ev) | |||
| } else { | |||
| log.Warnw("Thransport producer client error", "error", ev) | |||
agent/cmd/main.go
Outdated
| @@ -124,6 +124,8 @@ func parseFlags() *configs.AgentConfig { | |||
| "The agent running namespace, also used as leader election namespace") | |||
| pflag.IntVar(&agentConfig.SpecWorkPoolSize, "consumer-worker-pool-size", 10, | |||
| "The goroutine number to propagate the bundles on managed cluster.") | |||
| pflag.IntVar(&agentConfig.TransportConfig.FailureThreshold, "transport-failure-threshold", 10, | |||
| "Restart pod when tansport error count > transport-failure-threshold in 5 mins.") | |||
There was a problem hiding this comment.
Restart the pod if the transport error count exceeds the transport-failure-threshold within 5 minutes
clyang82
requested changes
Dec 3, 2024
| } else { | ||
| log.Warnw("Thransport producer client error", "error", ev) | ||
| log.Warnw("thransport producer client error", "error", ev) |
|
|
||
| errorCount++ | ||
| if errorCount >= transportFailureThreshold { | ||
| log.Panicf("thransport producer error > 10 in 5 minutes, error: %v", ev) |
Signed-off-by: ldpliu <[email protected]> Signed-off-by: root <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, ldpliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
https://issues.redhat.com/browse/ACM-14562
Fixes #
Tests
make unit-tests.make integration-test.make e2e-test-all.