fix manager do not recreted after delete manager deploy #1252
Conversation
ldpliu
force-pushed
the
debug-manager-lost
branch
from
9921b20
to
9d0e104
Compare
ldpliu
changed the title
| @@ -249,6 +250,7 @@ var secretPred = predicate.Funcs{ | |||
| } | |||
|
|
|||
| func (r *GrafanaReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | |||
| log.Infof("reconcile grafana controller") | |||
| @@ -61,6 +61,8 @@ func ReadyToEnableAddonManager(mgh *v1alpha4.MulticlusterGlobalHub) bool { | |||
| } | |||
|
|
|||
| func StartAddonManagerController(initOption config.ControllerOption) (config.ControllerInterface, error) { | |||
| log.Info("start acm controller") | |||
ldpliu
force-pushed
the
debug-manager-lost
branch
from
9d0e104
to
7a74b62
Compare
Signed-off-by: ldpliu <[email protected]>
ldpliu
force-pushed
the
debug-manager-lost
branch
from
7a74b62
to
9dec916
Compare
|
/retest |
|
/test test-integration |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, ldpliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ldpliu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Summary
When operator restart, the transport connection is null, so the controllers(manager) which depend on the transport connection will not be start. But when transport connection is set, the kafka component status in mgh is not updated, so controller-runtime will not trigger reconcile to start manager controller.
In this pr, we update the kafka component status in mgh when transport connection set.
The storage connection has the same problem, so we do it as the same way.
Related issue(s)
Fixes #
Tests
make unit-tests.make integration-test.make e2e-test-all.