-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-15718: Add Configuration Support for the SiteConfig Operator #132
CNF-15718: Add Configuration Support for the SiteConfig Operator #132
Conversation
ed3eea5
to
d5faf6a
Compare
/override ci/prow/sonar-pre-submit |
@sakhoury: Overrode contexts on behalf of sakhoury: ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "SonarCloud Code Analysis" |
@sakhoury: Overrode contexts on behalf of sakhoury: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d5faf6a
to
a3f9804
Compare
/override ci/prow/sonar-pre-submit |
@sakhoury: Overrode contexts on behalf of sakhoury: ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "SonarCloud Code Analysis" |
@sakhoury: Overrode contexts on behalf of sakhoury: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7e96213
to
331dcd1
Compare
/override ci/prow/sonar-pre-submit |
@sakhoury: Overrode contexts on behalf of sakhoury: ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "SonarCloud Code Analysis" |
@sakhoury: Overrode contexts on behalf of sakhoury: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/override ci/prow/sonar-pre-submit |
@sakhoury: Overrode contexts on behalf of sakhoury: ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments, otherwise looks good
This commit introduces functionality to manage the SiteConfig Operator's configuration via a ConfigMap. A new controller, `ConfigurationMonitor`, has been implemented to monitor and maintain the configuration. Key features include: - Automatic creation of the ConfigMap with default values during manager pod initialization if it doesn't exist. - Re-creation of the ConfigMap with default values if it is deleted. The following configuration fields are supported: - `AllowReinstalls`: Enables or disables the reinstall functionality. - `MaxConcurrentReconciles`: Sets the maximum number of `ClusterInstances` that can be processed concurrently. Unit tests have been added to validate the behavior of the new components. Signed-off-by: Sharat Akhoury <[email protected]>
331dcd1
to
2bd27b0
Compare
/override ci/prow/sonar-pre-submit |
@sakhoury: Overrode contexts on behalf of sakhoury: ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/sonar-pre-submit |
@sakhoury: Overrode contexts on behalf of sakhoury: SonarCloud Code Analysis, ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, sakhoury The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3b1dbc9
into
stolostron:main
Summary
This PR introduces functionality to manage the SiteConfig Operator's configuration via a ConfigMap.
A new controller,
ConfigurationMonitor
, has been implemented to monitor and maintain the configuration. Key features include:The following configuration fields are supported:
AllowReinstalls
: Enables or disables the reinstall functionality.MaxConcurrentReconciles
: Sets the maximum number ofClusterInstances
that can be processed concurrently.Unit tests have been added to validate the behavior of the new components.
Resolves: CNF-15718