feat: Adding the possibility of copying the link by clicking text and icons

[pierrbt]

I added the possibility to copy the link just by clicking the text on the upload dialog, and I also added a small check icon when the copying is done.

Tell me if you think something can be changed. I'll be happy to help for other things on this project, I've already used quite a lot TypeScript with React and also Vanilla NodeJS.

[stonith404]

Thank you, this is a nice addition!

In the file frontend/src/components/share/modals/showCompletedReverseShareModal.tsx is the exact same component, it would be nice if you can change it there too because else the design is inconsistent.

The best way would be if your create a new component e.g CopyTextField and use it in showCompletedReverseShareModal.tsx and showCreateUploadModal.tsx.

[pierrbt]

@stonith404, I've made the requested changes, let me know what you think about it

[stonith404]

Awesome, thank you! Just one thing; when I want to copy the link again, by pressing on the CopyTextField, it doesn't copy the link again. Is this on purpose or a bug?

[pierrbt]

when I want to copy the link again, by pressing on the CopyTextField, it doesn't copy the link again. Is this on purpose or a bug?

Yes, you can only copy the text itself once because if the user want to select it anyway, it would notificate 3x or more, so it selects only once on the text, but he can always click on the clipboard if he wants to copy it again.

I found disturbing that it displays multiple notifications if we only wanted to select the link.

I can change it if you want, it's only two lines :

const [textClicked, setTextClicked] = useState(false);

if (!textClicked) {
    copyLink();
    setTextClicked(true);
}

[pierrbt]

@stonith404

[stonith404]

Makes absolutely sense!

[stonith404]

Are you able to merge the PR or do I have to do it?

[pierrbt]

No I don't have write access, even with a review, I can't.