Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip install & use node-prune for arm64 image build #1985

Merged

Conversation

jsoizo
Copy link
Contributor

@jsoizo jsoizo commented Feb 10, 2022

Addresses #1966

Summary

For purpuse of support arm64 environment, skip to install and runnode-prune when build docker image.
And please build and publish arm64 docker image on Docker Hub.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

Additional context

@jsoizo jsoizo requested review from a team and chohmann and removed request for a team February 10, 2022 20:28
@jsoizo jsoizo changed the title skip install & use node-prune for aarch64 image build skip install & use node-prune for arm64 image build Feb 10, 2022
@chohmann
Copy link
Contributor

@jsoizo could you push an empty commit to your branch? The circle ci webhook that triggers the build failed. It also failed when we tried to redeliver it. We have re-installed the webhook through circle ci. I tried to push an empty commit to your branch myself, but it seems I don't have permissions to do that.

@jsoizo
Copy link
Contributor Author

jsoizo commented Feb 11, 2022

@chohmann

could you push an empty commit to your branch?

That’s done. When it still keep not working, I would try to add permissions of my forked repository to you.

@chohmann chohmann merged commit 123cb83 into stoplightio:master Feb 14, 2022
@jsoizo jsoizo deleted the feature/support-arm64-docker-build branch February 16, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants