Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1966 Adding Github Action for publishing multi-arch docker images #2300

Closed

Conversation

saturna
Copy link

@saturna saturna commented May 29, 2023

#1966 Adding Github Action for publishing multi-arch docker images

Github action that triggers docker image build and publish action upon:

  • merging into master using tag :master
  • creating a new Prism Release with tags: latest, ,

Additionally adding YARN_NETWORK_TIMEOUT to Dockerfile with default value set to Yarn's default. This extra argument increases network timeout for arm64 Docker image builds since QEMU emulation tends to be slow.

Addresses #1966

Summary

Currently, no ARM64 images are being published to DockerHub for Prism resulting in AMD64 emulation mode on ARM64 based systems.

Requirements
This Github action expects the following two secrets to be defined on the Github repository in order to push images to DockerHub:

  • DOCKERHUB_USERNAME
  • DOCKERHUB_TOKEN

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Testing Screenshots

Merge/Push to master:
image

Release Created:
image

Personal DockerHub build results:
image

@saturna saturna requested a review from a team as a code owner May 29, 2023 14:53
@saturna saturna requested review from chohmann and removed request for a team May 29, 2023 14:53
@chohmann
Copy link
Contributor

chohmann commented Jun 9, 2023

@saturna thank you for the PR! We really like this and want to make this happen. However, our current build/deploy stuff is all in circleci and not github actions, so we'll need to convert this over to be done in circleci. Since there's not really a good way for community members to test circleci config changes, we'll have to prioritize this amongst our team when we have capacity.

* merging into master using tag :master
* creating a new Prism Release with tags: latest, <major-version>, <full-version>

Additionally adding YARN_NETWORK_TIMEOUT to Dockerfile with default value set to Yarn's default.
This extra argument increases network timeout for arm64 Docker image builds since QEMU emulation tends to be slow.
@saturna saturna force-pushed the feature/multi-arch-docker-images branch from 2662a16 to 91eda86 Compare September 15, 2023 20:42
@saturna saturna closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants