feat: attach blocks to delegation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
approved these changes
Oct 22, 2024
alanshaw
added a commit
to storacha/storage
that referenced
this pull request
Oct 22, 2024
This PR allows configuration of the indexing service DID/URL and upgrades `publisher.Publish(...)` to make a `claim/cache` invocation to it. TODO: actually send the claim in the invocation blocks (needs ucanto upgrade). See: storacha/go-ucanto#27
alanshaw
added a commit
to storacha/storage
that referenced
this pull request
Oct 22, 2024
This PR allows configuration of the indexing service DID/URL and upgrades `publisher.Publish(...)` to make a `claim/cache` invocation to it. TODO: actually send the claim in the invocation blocks (needs ucanto upgrade). See: storacha/go-ucanto#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method
AttachtoDelegationthat allows additional blocks to be attached. The primary usecase is to allow blocks linked from capabilities or facts to be included in the delegation payload.Note: this feature exists in JS Ucanto already and it actually validates the blocks you attach are referenced from capabilities/facts. I will open an issue to track feature parity here assuming this is approved.