-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): minor changes & doc enhancements #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
changed the title
chore(main): minor fixes & doc enhancements
chore(main): minor changes & doc enhancements
Jan 16, 2025
fforbeck
force-pushed
the
chore/minor-fixes
branch
from
January 17, 2025 13:47
c1d9687
to
f4509bc
Compare
fforbeck
force-pushed
the
chore/minor-fixes
branch
from
January 17, 2025 13:54
f4509bc
to
5f9ac88
Compare
fforbeck
force-pushed
the
chore/minor-fixes
branch
from
January 17, 2025 13:55
5f9ac88
to
1d542d4
Compare
fforbeck
force-pushed
the
chore/minor-fixes
branch
from
January 17, 2025 13:57
1d542d4
to
7d7954b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
volmedo
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left some comments!
alanshaw
previously requested changes
Jan 17, 2025
volmedo
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
test
target to the Makefile.Opentofu
installation for different distros..terraform.lock.hcl
dependencies due to Linux installation.README.md
about potential failure in themake init
command.