tests: Do not ignore entire test files in pylint

storaged-project · Feb 7, 2024 · b497517 · b497517
1 parent ad73c87
commit b497517
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/tests/unit_tests/devicelibs_test/disk_test.py b/tests/unit_tests/devicelibs_test/disk_test.py
@@ -1,4 +1,3 @@
-# pylint: skip-file
 import unittest
 from unittest.mock import Mock, patch, sentinel
 
@@ -106,7 +105,7 @@ def system_by_id(sys_id):
                                               "volume_raid_info.side_effect": client_volume_raid_info})
                 _lsm.Client = client_mock
                 disklib.update_volume_info()
-                for (i, lvol) in enumerate(_client_volumes):
+                for (_i, lvol) in enumerate(_client_volumes):
                     bvol = disklib.volumes[lvol.nodes[0]]
                     system = system_by_id(lvol.system_id)
                     self.assertEqual(bvol.system, system.name)

diff --git a/tests/unit_tests/devices_test/disk_test.py b/tests/unit_tests/devices_test/disk_test.py
@@ -1,4 +1,3 @@
-# pylint: skip-file
 import unittest
 from unittest.mock import patch
 

diff --git a/tests/unit_tests/util_test.py b/tests/unit_tests/util_test.py
@@ -123,7 +123,7 @@ def test_requires_property(self):
         self.assertEqual(t.good_news, "Everything okay!")
 
         with self.assertRaises(ValueError):
-            t.bad_news
+            t.bad_news  # pylint: disable=pointless-statement
 
 
 class TestDependencyGuard(util.DependencyGuard):
@@ -146,7 +146,7 @@ def _test_dependency_guard_non_critical(self):
         return True
 
     def test_dependency_guard(self):
-        guard = TestDependencyGuard()
+        _guard = TestDependencyGuard()
         with self.assertLogs("blivet", level="WARNING") as cm:
             self.assertEqual(self._test_dependency_guard_non_critical(), None)
         self.assertTrue(TestDependencyGuard.error_msg in "\n".join(cm.output))