Include btrfs volumes names/labels in DeviceTreeBase.names #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwlehman
approved these changes
Oct 26, 2023
Btrfs Volumes use label of the filesystem as name in blivet, which isn't really a name, so it doesn't have to be unique, but not having it unique causes problems in both Blivet and Anaconda where we assume device name is a unique identifier. Not having the name in the list of names means newly created devices can get the same name as an already existing (or scheduled to be created) device.
vojtechtrefny
force-pushed
the
3.8-devel_btrfs-volumes-names
branch
from
92aa70d
to
1235788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btrfs Volumes use label of the filesystem as name in blivet, which isn't really a name, so it doesn't have to be unique, but not having it unique causes problems in both Blivet and Anaconda where we assume device name is a unique identifier. Not having the name in the list of names means newly created devices can get the same name as an already existing (or scheduled to be created) device.
@dwlehman btrfs volumes were explicitly excluded even before #688 Do you know about any issues adding btrfs volumes names to the list could cause? We are currently having two bugs reported related to this and the new Anaconda WebUI: https://bugzilla.redhat.com/show_bug.cgi?id=2237375 and https://bugzilla.redhat.com/show_bug.cgi?id=2237375