Use libblockdev FS plugin for filesystem operations #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
commented
Oct 27, 2023
|
Jenkins, test this please. |
vojtechtrefny
force-pushed
the
3.9-devel_libblockdev-fs-plugin
branch
2 times, most recently
from
bdb9f8d
to
674939c
Compare
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Oct 27, 2023
The next version of blivet will switch from calling the 'mount' command for mounting to libblockdev FS plugin (which use libmount) so the test needs to be changed. This way the check will work with both the old and the new blivet's code. Related: storaged-project/blivet#1163
vojtechtrefny
force-pushed
the
3.9-devel_libblockdev-fs-plugin
branch
2 times, most recently
from
f4cea18
to
b7ff2ab
Compare
vojtechtrefny
force-pushed
the
3.9-devel_libblockdev-fs-plugin
branch
from
b7ff2ab
to
6952fa3
Compare
|
Marking as ready for review, we are still missing some features, but these can be implemented later in a separated PR without blocking this. |
japokorn
reviewed
Nov 7, 2023
ReiserFs support is scheluded to be removed from the kernel and the userspace tools were removed in Fedora 35. This removes only support for creating and managing ReiserFS, we will still recognize the filesystem.
JFS is still supported but isn't really used or actively developed anymore. It also isn't packaged for CentOS/RHEL and not supported by libblockdev.
The minimum required version 1.41 was released 8 years ago, we can now safely assume it is available everywhere.
We now require libblockdev >= 3.0 which will always have these technologies.
libblockdev uses the FIFREEZE and FITHAW ioctls directly so we no longer need to require the command line tool.
BlockDev.swap.mkswap supports the UUID parameter directly since 3.0.
We can now use the FSInfo task to get the filesystem label too.
We still need to manually spawn mkfs for HFS and GFS2 which are not supported by libblockdev.
FormatCreateError doesn't accept the extra device name parameter.
HFS was replaced by HFS+ more than 20 years ago and is needed only for the old PowerPC Macs and PPC is not supported by Fedora.
Removing now unused applications replaced by libblockdev.
This is no longer needed since the full LVM devices file support introduced in storaged-project#972.
NTFS is now fully support, we no longer need to skip this test.
We can use the libblockdev utils instead of calling `modprobe`.
vojtechtrefny
force-pushed
the
3.9-devel_libblockdev-fs-plugin
branch
from
3f2ce4e
to
c2afd77
Compare
VladimirSlavik
pushed a commit
to VladimirSlavik/anaconda
that referenced
this pull request
Nov 16, 2023
The next version of blivet will switch from calling the 'mount' command for mounting to libblockdev FS plugin (which use libmount) so the test needs to be changed. This way the check will work with both the old and the new blivet's code. Related: storaged-project/blivet#1163 (cherry picked from commit 5cffb0c)
VladimirSlavik
pushed a commit
to VladimirSlavik/anaconda
that referenced
this pull request
Nov 20, 2023
The next version of blivet will switch from calling the 'mount' command for mounting to libblockdev FS plugin (which use libmount) so the test needs to be changed. This way the check will work with both the old and the new blivet's code. Related: storaged-project/blivet#1163 (cherry picked from commit 5cffb0c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libblockdev 3.0 now released and required in Blivet, we can now start using the FS plugin for various filesystem operations we previously used the command line tools directly.
Most of the changes are just replacing the function calls with libblockdev. One major change is removing some filesystem support. We'll remove support for creating and managing of ReiserFS, JFS and HFS. These filesystems are either unsupported (ReiserFS userspace tools were removed from Fedora and ReiserFS is also deprecated in the upstream kernel) or very old and not used (HFS is supported only on PPC Mac which is no longer supported in Fedora, we are not removing HFS+ support).
TODO:
ntfsresizeused by blivet vsntfsinfoused by libblockdev to get filesystem free space), we need to add support to libblockdev first