Fix DMDevice hard dependency on kpartx #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need kpartx for all DM devices (and devices that are based on it like LUKS or LVM) so we are moving the dependency to the MultipathDevice where we can expect partitions to be present on a device mapper device.
We don't need to fail just because kpartx is missing, we can just log warning and not activate the partitions.
vojtechtrefny
force-pushed
the
3.8-devel_kpartx-dependency
branch
from
96743c2
to
46ac2a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMDevicenow depends onkpartxwhich means all DM devices (LUKS, LVM etc.) depend onkpartxwhich is really needed only for multipath. This PR moves the dependency to multipath and also allows avoids unnecessary exceptions whenkpartxis not available.