Fstab cleanup fix #1197
Merged
Fstab cleanup fix #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japokorn
force-pushed
the
3.9-devel-fstab_cleanup_fix
branch
from
3c15dca
to
205d7d1
Compare
vojtechtrefny
requested changes
Feb 14, 2024
japokorn
force-pushed
the
3.9-devel-fstab_cleanup_fix
branch
from
205d7d1
to
c0dd3a4
Compare
Formats with multiple layers (e.g. LUKS) were not handled properly in fstab. This resulted in fstab entries not being properly cleaned from fstab when destroy actions were executed. This fixes the issue by using different variables with correct values based on action type.
japokorn
force-pushed
the
3.9-devel-fstab_cleanup_fix
branch
from
c0dd3a4
to
ef65def
Compare
Added the test. |
vojtechtrefny
approved these changes
Mar 6, 2024
vojtechtrefny
merged commit 8341d80
into
storaged-project:3.9-devel
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formats with multiple layers (e.g. LUKS) were not handled properly in fstab. This resulted in fstab entries not being properly cleaned from fstab when destroy actions were executed. This fixes the issue by using different variables with correct values based on action type.