blivet fstab method change #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blivet fstab methods get_device() and find_device() took Blivet object as a first parameter. However, for anaconda (primary customer for the blivet change) usecase the Blivet object does not always exist, only the Devicetree. Mentioned methods do not need anything else besides Devicetree from blivet object. This changes those methods interfaces to accept Devicetree insted of Blivet as the first parameter. Unit tests modified accordingly. Storage role should not be affected by this change.
vojtechtrefny
approved these changes
Jul 26, 2024
vojtechtrefny
merged commit d41a0ce
into
storaged-project:3.10-devel
10 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blivet fstab methods
get_device()andfind_device()tookBlivetobject as a first parameter. However, for anaconda (primary customer for the blivet change) usecase theBlivetobject does not always exist, only theDevicetree. Mentioned methods do not need anything else besidesDevicetreefrom blivet object.This changes those methods interfaces to accept
Devicetreeinstead ofBlivetas the first parameter.Unit tests modified accordingly.
Storage role should not be affected by this change.