-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using libbtrfsutil in the btrfs plugin #552
Comments
One downside I noticed here is that libbtrsutil is not actually used by the If libblockdev wants to extend btrfs information, then libbrtfsutil needs to be extended. |
Isn't it linked statically? Sometimes distros tend to link everything statically for initramfs use.
Theoretically we may opt for a mixed use - library calls for most of the stuff and external tools as a fallback for missing functionality. Assuming both the library and the tools are part of a single package. |
I think I might have looked at it wrong, this struct is indeed re-used in the cli interface https://github.com/search?q=repo%3Akdave%2Fbtrfs-progs+btrfs_util_subvolume&type=code And FYI there is a list of things which are required for snapper and implemented in libbtrfsutil. |
libbtrfsutil was added in 2018 (btrfs-progs 4.16), we should consider using it in the btrfs plugin instead of calling btrfs tools and parsing their output. It looks like it supports everything we need (but we should take a closer look first to be 100 % sure).
The text was updated successfully, but these errors were encountered: