Btrfs support in filesystem plugin #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbzatek
reviewed
Nov 24, 2020
| GError *local_error = NULL; | ||
| BDFSBtrfsInfo* btrfs_info = NULL; | ||
|
|
||
| mountpoint = fs_mount (device, "btrfs", &unmount, error); |
There was a problem hiding this comment.
Hint: we should be using separate mount namespace for this, someday.
vojtechtrefny
force-pushed
the
master_btrfs-as-fs
branch
from
74cc505
to
29c9411
Compare
tbzatek
approved these changes
Nov 25, 2020
vojtechtrefny
force-pushed
the
master_btrfs-as-fs
branch
2 times, most recently
from
7195fcf
to
6678ea3
Compare
vojtechtrefny
force-pushed
the
master_btrfs-as-fs
branch
from
6678ea3
to
78a3810
Compare
|
Rebased to latest master and removed the UDF commit. UDF PR needs to be fixed so we can merge this first. |
vojtechtrefny
force-pushed
the
master_btrfs-as-fs
branch
from
78a3810
to
67287d1
Compare
This is intended for use case where btrfs is used as a "normal" filesystem on a single device and not as a "volume manager".
We need bigger devices for Btrfs which needs at least 256 MiB.
vojtechtrefny
force-pushed
the
master_btrfs-as-fs
branch
from
67287d1
to
073f8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are from #583 and #585.
The idea here is to provide functions for users that want to use btrfs as a filesystem and not as a volume manager. This implementation also uses only the command line tools so there are no compile time dependencies (as opposed to the btrfs plugin which we plan to rewrite to use libbtrfsutil library, see #552).
Few highlights:
resizeandget_infofunctions will fail when called on filesystem that is part of a multidevice btrfs volume. This is indented and we want users to use btrfs plugin for these. Other functions do not check number of btrfs devices and should generally work, but we'll encourage people to not use these on multidevice btrfs volumes.resize,set_label...) take moutpoint as an argument and not the device. We already do this for some xfs functions and it probably makes more sense than taking device that must be mounted. The generic functions for resize and other actions that require the device to be mounted will temporarily mount the device if necessary.