crypto: Add support for LUKS Reencryption. #1065
Conversation
xyakimo1
force-pushed
the
master
branch
3 times, most recently
from
8c026ec
to
9134237
Compare
| * Returns: 0, if the reencryption should continue. | ||
| * A non-zero value to stop the reencryption | ||
| */ | ||
| typedef int (*BDCryptoLUKSReencryptProgFunc) (guint64 size, guint64 offset); |
There was a problem hiding this comment.
Please provide another argument - gpointer user_data. This is a good practice with Glib callbacks to pass through user data that the caller will use for a back-reference. Nothing special, just pass the value. All the functions that take BDCryptoLUKSReencryptProgFunc in will need to be extended with this gpointer user_data argument as well.
I wasn't able to find any nice writeup, this is perhaps close to what I'm talking about: https://www.geany.org/manual/gtk/gtk-tutorial/x159.html
Better to talk to @vojtechtrefny first, I don't remember exactly what is the style of callbacks in libblockdev.
| g_free (params->resilience); | ||
| g_free (params->hash); | ||
| bd_crypto_luks_pbkdf_free(params->pbkdf); | ||
| } |
There was a problem hiding this comment.
You forgot to free params itself ;-)
| BD_CRYPTO_LUKS_REENCRYPT_CLEAN, | ||
| BD_CRYPTO_LUKS_REENCRYPT_CRASH, | ||
| BD_CRYPTO_LUKS_REENCRYPT_INVALID | ||
| } BDCryptoLUKSReencryptStatus; |
There was a problem hiding this comment.
Looking at bd_crypto_luks_reencrypt_status(), does it make sense to include status values like "running" or "finished"?
| BD_CRYPTO_LUKS_REENCRYPT_NONE = 0, | ||
| BD_CRYPTO_LUKS_REENCRYPT_CLEAN, | ||
| BD_CRYPTO_LUKS_REENCRYPT_CRASH, | ||
| BD_CRYPTO_LUKS_REENCRYPT_INVALID |
There was a problem hiding this comment.
Please also document enum values.
| * Returns: true, if the reencryption was successful or gracefully stopped with @prog_func. | ||
| * false, if an error occurred. |
There was a problem hiding this comment.
As this is a long-running operation, I (as an user) would like to know whether this is a blocking call or not. I.e. whether this is a synchronous operation or just a trigger to start an operation in the background. If this is a blocking call, would be good to warn user that this may take hours or days to complete.
| * Returns: true, if the reencryption finished successfully or was gracefully stopped with @prog_func. | ||
| * false, if an error occurred. |
There was a problem hiding this comment.
Just like above, would be good to know if this call blocks until the operation is finished or if it just resumes an operation in the background.
No description provided.