udiskslinuxdevice: Fix dm-multipath ATA drives handling #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
The dm-multipath devices are actually capable of tunneling ioctls down to the drive through an active path. It might be actually dangerous to approach the particular paths directly, in parallel or async. This change refrains from any probing on ATA devices which are part of a dm-multipath device. The actual dm-multipath device is probed instead. However the dm-multipath device carries only a small number of udev attributes that still need to be retrieved from the particular path.
|
Jenkins, test this please. |
tbzatek
changed the title
|
/packit build |
vojtechtrefny
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dm-multipath devices are actually capable of tunneling ioctls down to the drive through an active path. It might be actually dangerous to approach the particular paths directly, in parallel or async.
This change refrains from any probing on ATA devices which are part of a dm-multipath device. The actual dm-multipath device is probed instead.
However the dm-multipath device carries only a small number of udev attributes that still need to be retrieved from the particular path.
TODO (future PR):
Needs storaged-project/libblockdev#1033