Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Allow specifying custom housekeeping interval #1315

Closed
wants to merge 1 commit into from

Conversation

tbzatek
Copy link
Member

@tbzatek tbzatek commented Sep 26, 2024

This allows to override the default housekeeping interval in configure time via the new --with-housekeeping-interval=MIN option.

Fixes #892
Fixes #407

This allows to override the default housekeeping interval in configure
time via the new --with-housekeeping-interval=MIN option.
Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like adding a new configure option for this, but I guess I can live with it.

@tbzatek
Copy link
Member Author

tbzatek commented Sep 27, 2024

I don't like adding a new configure option for this, but I guess I can live with it.

So here's the deal:

  • the configure option brings certain maintenance burden in case we decide to replace it with something below:
  • any arbitrary timeout will never suit all the users, historically we've been asked to increase the timeout to 15, 30 minutes or 1 hour, etc.
  • timeout would be good to have configurable per-device
  • timeout is requested to be configurable through config files
  • another possibility is to introduce new udev property (which in terms of device matching makes much more sense to me than config files)
  • housekeeping timeout is global and is run for all operations for all devices in a sequential order in side thread, this needs to be refactored first
  • I don't have time to work on any of these near-term, chance for a community to implement proper solution

@tbzatek tbzatek closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants