Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

Fix: check on justfile #6

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix: check on justfile #6

merged 1 commit into from
Aug 16, 2024

Conversation

jaoleal
Copy link
Contributor

@jaoleal jaoleal commented Aug 8, 2024

now check in justfile evoke compile-all.sh

@jaoleal jaoleal requested a review from storopoli as a code owner August 8, 2024 23:03
justfile Outdated Show resolved Hide resolved
Copy link
Owner

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of crap artifacts like the whole output/ dir

@jaoleal
Copy link
Contributor Author

jaoleal commented Aug 11, 2024

There's a bunch of crap artifacts like the whole output/ dir

Its where the compiled things go, wanna change ?

@jaoleal
Copy link
Contributor Author

jaoleal commented Aug 12, 2024

Done and rebased. Wonder if the "check" thing is sounds more like "Check if my code is correct"; if it is so, we could do a python script that matches the output of the solution and the code done by the students. Otherwise "check if my c code is compiling"

@storopoli
Copy link
Owner

Done and rebased. Wonder if the "check" thing is sounds more like "Check if my code is correct"; if it is so, we could do a python script that matches the output of the solution and the code done by the students. Otherwise "check if my c code is compiling"

No python please...

@jaoleal
Copy link
Contributor Author

jaoleal commented Aug 12, 2024

No python please...

it's his only purpose, scripting...

justfile Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@storopoli
Copy link
Owner

No python please...

it's his only purpose, scripting...

Yeah tell this to a first-year undergraduate using the repo...

justfile Show resolved Hide resolved
Compile the C code in "code/"
@jaoleal
Copy link
Contributor Author

jaoleal commented Aug 15, 2024

Did the requested changes, looks like that just`s built in commands doesnt work well while using shebangs...

@jaoleal jaoleal requested a review from storopoli August 15, 2024 21:17
@storopoli storopoli enabled auto-merge August 16, 2024 09:13
@storopoli storopoli disabled auto-merge August 16, 2024 09:14
@storopoli storopoli merged commit 71d4af2 into storopoli:main Aug 16, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants