feat: moving cookie related logic to cookieAdapter.ts #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BibiSebi
commented
Jul 8, 2024
BibiSebi
force-pushed
the
SHAPE-5999-showcase-extracting-logic-to-public-adapter
branch
from
fd84bc8 to
2138fca
Compare
eunjae-lee
reviewed
Jul 8, 2024
eunjae-lee
reviewed
Jul 8, 2024
eunjae-lee
reviewed
Jul 8, 2024
BibiSebi
commented
Jul 9, 2024
| @@ -19,41 +20,49 @@ const createScopedKey = ({ | |||
| // We do not use `clientId` in cookie adapter, | |||
| // because different plugins will have different domain names, | |||
| // and it's enough to differentiate these cookie values. | |||
|
|
|||
| const sessionKey = 'sb.auth' | |||
| //NOTE: possibly cookieAdapter can become createCookieAdapter(key: string) | |||
There was a problem hiding this comment.
WDYT about this comment @eunjae-lee ?
There was a problem hiding this comment.
if you agree with this I will also need to change a bit the docs (just a note for myself)
There was a problem hiding this comment.
Yeah agree with create... naming
BibiSebi
force-pushed
the
SHAPE-5999-showcase-extracting-logic-to-public-adapter
branch
from
2367d42 to
474cc58
Compare
BibiSebi
commented
Jul 10, 2024
BibiSebi
commented
Jul 10, 2024
BibiSebi
commented
Jul 10, 2024
BibiSebi
commented
Jul 10, 2024
| @@ -12,7 +12,7 @@ export const changedCookieHeaderValue = ( | |||
| return [ | |||
| `${name}=${value}`, | |||
| 'path=/', | |||
| expires ? `Expires=${expires.toISOString()}; ` : undefined, | |||
| expires ? `Expires=${expires}; ` : undefined, | |||
There was a problem hiding this comment.
@eunjae-lee I changes this because it did not work for me and the expires attribute was set to Session, now it seems to work. Please could you double-check?
There was a problem hiding this comment.
You're right. I've just confirmed it!
…e able to pass custom sessionKey - minor function extraction for better readability
eunjae-lee
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR
cookieAdapter)inferSessionQueryWhy?
To reduce complexity of the underlying abstraction layers, it makes sense to move the responsibility of the implementation to the upper highest level - in this scenario
cookieAdapter. In future there will be other adapters living on the same level as cookieAdapter which can be used interchangeably. The consumption of adapter is done inside app-extension-auth however the specific details on which structure to store the session in or how to encode and decode should be in the hands of the public adapter (e.g.: cookieAdapter, or in future other adapters)