docs(picker-starter): add giget instruction #90
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
picker-starter/README.md
Outdated
| yarn build | ||
|
|
||
| # Deploy it using the CLI | ||
| npx @storyblok/field-plugin-cli@latest deploy |
There was a problem hiding this comment.
We already have deploy command in scripts of package.json. Why don't we put it here like yarn deploy?
Btw, I've check the package.json and
"deploy": "npm run build && npx @storyblok/field-plugin-cli@latest deploy --name sb-picker-starter --scope partner-portal"
We should probably remove --name sb-picker-starter --scope partner-portal. What do you think?
There was a problem hiding this comment.
I tried to keep the package.json file unchanged to avoid the need to modify also the workflows/picker-starter.yml, but since you mentioned it, I think it will be better to move these options from the deploy script to the workflow.
I did it here
Thanks for your suggestion, @eunjae-lee.
There was a problem hiding this comment.
@demetriusfeijoo ah that's why. yeah, now that parameters live on this root level of this repository, and the cloned project will no longer have sb-picker-starter stuff. Looks great! :D
demetriusfeijoo
force-pushed
the
EXT-2143-add-readme-instruction-to-fetch-this-starter-using-giget
branch
from
d40f8a0 to
dcc2fc4
Compare
demetriusfeijoo
deleted the
EXT-2143-add-readme-instruction-to-fetch-this-starter-using-giget
branch
Issue: EXT-2143
What?
Add giget instruction on README.
Why?
Using Giget will make developer's lives easier since it will not require them to clone all this repositories and then, after, clean up the other projects they don't want from it.
[View Rendered →]