Require phpstan/phpstan 2
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 92.18% 92.18%
Complexity 295 295
=========================================
Files 64 64
Lines 1152 1152
=========================================
Hits 1062 1062
Misses 90 90 ☔ View full report in Codecov by Sentry. |
silasjoisten
requested changes
Feb 12, 2025
edodusi
requested changes
Feb 12, 2025
OskarStark
commented
Feb 12, 2025
Comment on lines
+88
to
+91
| message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertEmpty\(\) with Storyblok\\Api\\Domain\\Value\\Filter\\FilterCollection will always evaluate to false\.$#' | ||
| identifier: staticMethod.impossibleType | ||
| count: 2 | ||
| path: tests/Unit/Domain/Value/Filter/FilterCollectionTest.php |
There was a problem hiding this comment.
This is a false positive, otherwise our test would fail
OskarStark
commented
Feb 12, 2025
| @@ -27,7 +27,7 @@ public function __construct( | |||
| } | |||
|
|
|||
| /** | |||
| * @param array<string, list<string>> $headers | |||
| * @param array<string, array<string>> $headers | |||
There was a problem hiding this comment.
This fixes some errors, but I am in favor of keeping the list
|
ping @silasjoisten @edodusi |
silasjoisten
approved these changes
Feb 19, 2025
edodusi
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.