Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compatibility for symfony/cache 7 #103

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

roberto-butti
Copy link
Collaborator

  • symfony/cache 7 support
  • phpstan 1.10
  • updating php-cs-fixer

Pull request type

Jira Link: INT-

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe): supporting symfony/cache 7

How to test this PR

running composer run all-check

What is the new behavior?

Other information

- symfony/cache 7 support
- phpstan 1.10
- updating php-cs-fixer
@roberto-butti roberto-butti requested a review from joaokamun March 5, 2024 16:28
Copy link
Member

@ademarCardoso ademarCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end.

With this change, I noticed that it changed the imports in some places, would this be a breaking change, would it change anything for the imports for the end users?

I leave it approved because everything is right from my point of view.

@roberto-butti roberto-butti merged commit 0507b9e into master Mar 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants