Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify imports #243

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Simplify imports #243

merged 9 commits into from
Dec 17, 2024

Conversation

JReinhold
Copy link
Collaborator

@JReinhold JReinhold commented Dec 13, 2024 •
edited
Loading

Closes #229, implements #229 (comment)

  • Add SvelteKit to correctly get the default $lib alias
  • Move all files to src/lib
  • Remove subpath imports and replace with $lib alias
  • Add explicit .js extensions and /index.js to dir imports

@JReinhold JReinhold marked this pull request as ready for review December 13, 2024 14:03
@JReinhold JReinhold requested a review from xeho91 December 13, 2024 14:03
@JReinhold JReinhold self-assigned this Dec 13, 2024
@JReinhold JReinhold added bug Something isn't working patch Increment the patch version when merged labels Dec 13, 2024
@JReinhold
Copy link
Collaborator Author

Need to work out the last details to silent SvelteKit errors during build.

@JReinhold JReinhold marked this pull request as draft December 13, 2024 14:06
@JReinhold JReinhold marked this pull request as ready for review December 17, 2024 21:11
@JReinhold JReinhold merged commit d54d4b5 into next Dec 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeho91 xeho91 Awaiting requested review from xeho91

Assignees

@JReinhold JReinhold

Labels
bug Something isn't working patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JReinhold