-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to 7.0 and fix search shortcut #57
base: main
Are you sure you want to change the base?
Conversation
Force-pushed to rebase onto latest |
Force-pushed to rebase onto latest |
@winkerVSbecks — Running into some type errors: https://github.com/storybookjs/components-marketing/actions/runs/5137992820/jobs/9246810350?pr=57 I think I can fix most of them, but these two require some domain knowledge that I don't share: Error: src/components/SubNav/SubNavTabs.tsx(37,27): error TS2339: Property 'href' does not exist on type 'ItemProps'.
Error: src/components/SubNav/SubNavTabs.tsx(37,51): error TS2339: Property 'LinkWrapper' does not exist on type 'ItemProps'. Looks like the Chromatic baseline is messed up, too. :( |
bb4a752
to
c65b675
Compare
- Clean up `.storybook/main.js` - Rename `Intro.stories.mdx` -> `Intro.mdx` - Update `stories` globs
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What is eval?Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior. Avoid packages that use eval, since this could potentially execute any code. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
…odule Y but cannot be named' error
📦 Published PR as canary version:
2.1.4--canary.57.fbe2ee4.0
✨ Test out this PR locally via: