Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 7.0 and fix search shortcut #57

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

upgrade to 7.0 and fix search shortcut #57

wants to merge 11 commits into from

Conversation

winkerVSbecks
Copy link
Collaborator

@winkerVSbecks winkerVSbecks commented Nov 25, 2022

📦 Published PR as canary version: 2.1.4--canary.57.fbe2ee4.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@kylegach
Copy link
Collaborator

Force-pushed to rebase onto latest main.

@kylegach
Copy link
Collaborator

Force-pushed to rebase onto latest main and update to latest SB 7.

@kylegach
Copy link
Collaborator

kylegach commented May 31, 2023

@winkerVSbecks — Running into some type errors: https://github.com/storybookjs/components-marketing/actions/runs/5137992820/jobs/9246810350?pr=57

I think I can fix most of them, but these two require some domain knowledge that I don't share:

Error: src/components/SubNav/SubNavTabs.tsx(37,27): error TS2339: Property 'href' does not exist on type 'ItemProps'.
Error: src/components/SubNav/SubNavTabs.tsx(37,51): error TS2339: Property 'LinkWrapper' does not exist on type 'ItemProps'.

Looks like the Chromatic baseline is messed up, too. :(

@winkerVSbecks winkerVSbecks force-pushed the sb-7 branch 2 times, most recently from bb4a752 to c65b675 Compare August 22, 2023 18:49
@storybookjs storybookjs deleted a comment from socket-security bot Aug 22, 2023
@storybookjs storybookjs deleted a comment from socket-security bot Aug 22, 2023
@socket-security
Copy link

socket-security bot commented Aug 22, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
typescript 4.7.4...5.1.6 None +0/-0 40.1 MB typescript-bot
@babel/node 7.15.4...7.22.10 shell +11/-51 4.07 MB nicolo-ribaudo
@babel/cli 7.15.4...7.22.10 shell +9/-110 4.26 MB nicolo-ribaudo
chromatic 5.9.2...5.10.2 shell +13/-170 4.92 MB ndelangen
patch-package 6.4.7...6.5.1 None +1/-15 357 kB ds300
sort-package-json 1.51.0...1.57.0 None +0/-13 23.3 kB keithamus
prettier 2.4.0...2.8.8 environment +0/-0 11.2 MB prettier-bot
auto 10.37.4...10.46.0 None +4/-103 41.1 MB alisowski

🚮 Removed packages: @babel/[email protected], @babel/[email protected], @babel/[email protected], @babel/[email protected], @babel/[email protected], @babel/[email protected], @docsearch/[email protected], @docsearch/[email protected], @emotion/[email protected], @emotion/[email protected], @floating-ui/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

@socket-security
Copy link

socket-security bot commented Aug 22, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author puppeteer-core 2.1.1
Uses eval puppeteer-core 2.1.1
New author querystring 0.2.1
New author sshpk 1.17.0
New author for-each 0.3.3
New author tar 6.1.12
New author defaults 1.0.4
New author handlebars 4.7.8
New author convert-source-map 2.0.0
New author assert 2.0.0
New author semver 7.3.8
New author fd-slicer 1.1.0
Shell access @aw-web-design/x-default-browser 1.4.126
Shell access esbuild 0.18.20
Shell access jake 10.8.5
Shell access jake 10.8.7
Shell access jscodeshift 0.14.0
Shell access shelljs 0.8.5
Shell access update-browserslist-db 1.0.10
Shell access update-browserslist-db 1.0.11
Uses eval ejs 3.1.9
Uses eval envinfo 7.10.0

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants