Update components-marketing #47
Conversation
kylegach
commented
May 15, 2024
kylegach
commented
- See: Fix global navigation for the new homepage for SB8 components-marketing#74
- Address breaking changes
- See: storybookjs/components-marketing#74 - Address breaking changes
✅ Deploy Preview for storybook-status ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Need to use `transpilePackages` config option
|
@yannbf — Does this preview look correct to you? https://deploy-preview-47--storybook-status.netlify.app/status |
next.config.js
Outdated
| @@ -4,6 +4,7 @@ const nextConfig = { | |||
| swcMinify: true, | |||
| basePath: process.env.NEXT_PUBLIC_BASE_PATH, | |||
| staticPageGenerationTimeout: 900, // equivalent to netlify's timeout | |||
| transpilePackages: ['@storybook/components-marketing'], | |||
There was a problem hiding this comment.
@yannbf — This is to fix the issue with @storybook/api/shortcut.
- That package is used by
@storybook/components-marketing, to display the keyboard shortcut for the search in the header. @storybook/components-marketinghas a dependency on"@storybook/api": "^6.5.9", so it's not a matter of theapipackage being removed in SB 7- It's instead a transpilation error, thus this new config (and the upgrade to next 13.1 to be able to use it)
There was a problem hiding this comment.
This issue propagated to Storybook as well, I fixed it by patching the @storybook/components-marketing package. Instead of importing from @storybook/api/shortcut, importing from @storybook/manager-api instead.
I think it would make more sense if @storybook/components-marketing stopped depending on @storybook/api and just copied those minimal functions to use internally
Looks pretty good! Thanks for the fixes <3 |
