Skip to content

Commit

Permalink
Revert "Build: Add workaround resolution for Angular sandboxes"
Browse files Browse the repository at this point in the history
  • Loading branch information
yannbf authored Nov 23, 2024
1 parent 786e328 commit 5419509
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 0 additions & 3 deletions scripts/tasks/sandbox-parts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,6 @@ export const install: Task['run'] = async ({ sandboxDir, key }, { link, dryRun,
'svelte-vite/default-ts',
'vue3-vite/default-js',
'vue3-vite/default-ts',
'angular-cli/15-ts',
'angular-cli/default-ts',
'angular-cli/prerelease',
];
if (sandboxesNeedingWorkarounds.includes(key)) {
await addWorkaroundResolutions({ cwd, dryRun, debug });
Expand Down
5 changes: 3 additions & 2 deletions scripts/utils/yarn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export const addPackageResolutions = async ({ cwd, dryRun }: YarnOptions) => {
packageJson.resolutions = {
...packageJson.resolutions,
...storybookVersions,
'enhanced-resolve': '~5.10.0', // TODO, remove this
// this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
'@swc/core': '1.5.7',
playwright: '1.48.1',
Expand Down Expand Up @@ -84,8 +85,8 @@ export const addWorkaroundResolutions = async ({ cwd, dryRun }: YarnOptions) =>
'@testing-library/dom': '^9.3.4',
'@testing-library/jest-dom': '^6.5.0',
'@testing-library/user-event': '^14.5.2',
// TODO: Remove this once this issue is fixed https://github.com/thednp/position-observer/issues/1
'@thednp/shorty': '2.0.7',
// TODO: Remove as soon as @storybook/[email protected] is released
'@storybook/csf': '0.1.10--canary.d841bb4.0',
};
await writeJSON(packageJsonPath, packageJson, { spaces: 2 });
};
Expand Down

0 comments on commit 5419509

Please sign in to comment.