fixes

storybookjs · Nov 29, 2023 · 5a33607 · 5a33607
1 parent 0db9c48
commit 5a33607
Show file tree

Hide file tree

Showing 12 changed files with 85 additions and 53 deletions.
diff --git a/code/lib/manager-api/src/index.tsx b/code/lib/manager-api/src/index.tsx
@@ -305,6 +305,7 @@ function ManagerConsumer<P = Combo>({
   const comboData = filterer.current(managerContext);
 
   const comboDataArray = useMemo(() => {
+    // @ts-expect-error (No overload matches this call)
     return [...Object.entries(comboData).reduce((acc, keyval) => acc.concat(keyval), [])];
   }, [managerContext.state]);
 
@@ -412,6 +413,7 @@ export function useSharedState<S>(stateId: string, defaultState?: S) {
 
   useEffect(() => {
     if (quicksync) {
+      // @ts-expect-error (Argument of type 'S | undefined' is not assignable)
       api.setAddonState<S>(stateId, defaultState);
     }
   }, [quicksync]);

diff --git a/code/lib/manager-api/src/lib/store-setup.ts b/code/lib/manager-api/src/lib/store-setup.ts
@@ -5,9 +5,11 @@ import { parse, stringify } from 'telejson';
 // setting up the store, overriding set and get to use telejson
 export default (_: any) => {
   _.fn('set', function (key: string, data: object) {
+    // @ts-expect-error('this' implicitly has type 'any')
     return _.set(this._area, this._in(key), stringify(data, { maxDepth: 50 }));
   });
   _.fn('get', function (key: string, alt: string) {
+    // @ts-expect-error('this' implicitly has type 'any')
     const value = _.get(this._area, this._in(key));
     return value !== null ? parse(value) : alt || value;
   });

diff --git a/code/lib/manager-api/src/lib/stories.ts b/code/lib/manager-api/src/lib/stories.ts
@@ -21,7 +21,6 @@ import type {
   API_HashEntry,
   SetStoriesPayload,
   StoryIndexV2,
-  Renderer,
 } from '@storybook/types';
 // eslint-disable-next-line import/no-cycle
 import { type API, combineParameters, type State } from '../index';

diff --git a/code/lib/manager-api/src/modules/channel.ts b/code/lib/manager-api/src/modules/channel.ts
@@ -56,12 +56,12 @@ export const init: ModuleFn<SubAPI, SubState> = ({ provider }) => {
   const api: SubAPI = {
     getChannel: () => provider.channel,
     on: (type, handler) => {
-      provider.channel.on(type, handler);
+      provider.channel?.on(type, handler);
 
-      return () => provider.channel.off(type, handler);
+      return () => provider.channel?.off(type, handler);
     },
-    off: (type, handler) => provider.channel.off(type, handler),
-    once: (type, handler) => provider.channel.once(type, handler),
+    off: (type, handler) => provider.channel?.off(type, handler),
+    once: (type, handler) => provider.channel?.once(type, handler),
     emit: (type, data, ...args) => {
       if (
         data?.options?.target &&
@@ -73,7 +73,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({ provider }) => {
             ? `storybook-ref-${data.options.target}`
             : 'storybook-preview-iframe';
       }
-      provider.channel.emit(type, data, ...args);
+      provider.channel?.emit(type, data, ...args);
     },
     collapseAll: () => {
       api.emit(STORIES_COLLAPSE_ALL, {});

diff --git a/code/lib/manager-api/src/modules/globals.ts b/code/lib/manager-api/src/modules/globals.ts
@@ -35,14 +35,14 @@ export interface SubAPI {
 export const init: ModuleFn<SubAPI, SubState> = ({ store, fullAPI, provider }) => {
   const api: SubAPI = {
     getGlobals() {
-      return store.getState().globals;
+      return store.getState().globals as Globals;
     },
     getGlobalTypes() {
-      return store.getState().globalTypes;
+      return store.getState().globalTypes as GlobalTypes;
     },
     updateGlobals(newGlobals) {
       // Only emit the message to the local ref
-      provider.channel.emit(UPDATE_GLOBALS, {
+      provider.channel?.emit(UPDATE_GLOBALS, {
         globals: newGlobals,
         options: {
           target: 'storybook-preview-iframe',
@@ -62,7 +62,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({ store, fullAPI, provider }) =
     }
   };
 
-  provider.channel.on(
+  provider.channel?.on(
     GLOBALS_UPDATED,
     function handleGlobalsUpdated(this: any, { globals }: { globals: Globals }) {
       const { ref } = getEventMetadata(this, fullAPI)!;
@@ -78,7 +78,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({ store, fullAPI, provider }) =
   );
 
   // Emitted by the preview on initialization
-  provider.channel.on(
+  provider.channel?.on(
     SET_GLOBALS,
     function handleSetStories(this: any, { globals, globalTypes }: SetGlobalsPayload) {
       const { ref } = getEventMetadata(this, fullAPI)!;

diff --git a/code/lib/manager-api/src/modules/layout.ts b/code/lib/manager-api/src/modules/layout.ts
@@ -385,7 +385,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({ store, provider, singleStory
 
   const persisted = pick(store.getState(), 'layout', 'selectedPanel');
 
-  provider.channel.on(SET_CONFIG, () => {
+  provider.channel?.on(SET_CONFIG, () => {
     api.setOptions(merge(api.getInitialOptions(), persisted));
   });
 

diff --git a/code/lib/manager-api/src/modules/refs.ts b/code/lib/manager-api/src/modules/refs.ts
@@ -295,6 +295,7 @@ export const init: ModuleFn<SubAPI, SubState> = (
             )
           : storyIndex;
 
+        // @ts-expect-error (could be undefined)
         index = transformStoryIndexToStoriesHash(storyIndex, {
           provider,
           docsOptions,

diff --git a/code/lib/manager-api/src/modules/shortcuts.ts b/code/lib/manager-api/src/modules/shortcuts.ts
@@ -392,7 +392,7 @@ export const init: ModuleFn = ({ store, fullAPI, provider }) => {
     });
 
     // Also listen to keydown events sent over the channel
-    provider.channel.on(PREVIEW_KEYDOWN, (data: { event: KeyboardEventLike }) => {
+    provider.channel?.on(PREVIEW_KEYDOWN, (data: { event: KeyboardEventLike }) => {
       api.handleKeydownEvent(data.event);
     });
   };