Skip to content

Commit

Permalink
Merge pull request #24586 from storybookjs/kasper/bench-sandboxes-rem…
Browse files Browse the repository at this point in the history
…ove-dev

Build: Remove inDevelopment for new bench sandboxes
  • Loading branch information
kasperpeulen authored Oct 26, 2023
2 parents 047a9a6 + 0761358 commit f505c63
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
16 changes: 8 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -499,11 +499,11 @@ workflows:
requires:
- unit-tests
- create-sandboxes:
parallelism: 12
parallelism: 14
requires:
- build
- build-sandboxes:
parallelism: 12
parallelism: 14
requires:
- create-sandboxes
- chromatic-sandboxes:
Expand All @@ -523,7 +523,7 @@ workflows:
requires:
- build-sandboxes
- bench:
parallelism: 3
parallelism: 5
requires:
- build-sandboxes
# TODO: reenable once we find out the source of flakyness
Expand Down Expand Up @@ -555,11 +555,11 @@ workflows:
requires:
- unit-tests
- create-sandboxes:
parallelism: 21
parallelism: 23
requires:
- build
- build-sandboxes:
parallelism: 21
parallelism: 23
requires:
- create-sandboxes
- chromatic-sandboxes:
Expand All @@ -579,7 +579,7 @@ workflows:
requires:
- build-sandboxes
- bench:
parallelism: 3
parallelism: 5
requires:
- build-sandboxes
# TODO: reenable once we find out the source of flakyness
Expand Down Expand Up @@ -609,14 +609,14 @@ workflows:
requires:
- build
- create-sandboxes:
parallelism: 36
parallelism: 38
requires:
- build
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
parallelism: 36
parallelism: 38
requires:
- create-sandboxes
- chromatic-sandboxes:
Expand Down
2 changes: 0 additions & 2 deletions code/lib/cli/src/sandbox-templates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,6 @@ const benchTemplates = {
'bench/react-vite-default-ts-test-build': {
...baseTemplates['react-vite/default-ts'],
name: 'Bench (react-vite/default-ts, test-build)',
inDevelopment: true,
isInternal: true,
modifications: {
skipTemplateStories: true,
Expand All @@ -574,7 +573,6 @@ const benchTemplates = {
'bench/react-webpack-18-ts-test-build': {
...baseTemplates['react-webpack/18-ts'],
name: 'Bench (react-webpack/18-ts, test-build)',
inDevelopment: true,
isInternal: true,
modifications: {
skipTemplateStories: true,
Expand Down

0 comments on commit f505c63

Please sign in to comment.