-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls: Fix select / multiselect when value contains multiple spaces #22334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
requested review from
yannbf,
valentinpalkovic,
JReinhold,
cdedreuille,
kasperpeulen and
ndelangen
as code owners
August 29, 2023 10:57
JReinhold
added
addon: controls
ci:daily
Run the CI jobs that normally run in the daily job.
labels
Aug 29, 2023
JReinhold
changed the title
Fix select and multiselect controls not working when value contains multiple spaces
Controls: Fix select and multiselect controls not working when value contains multiple spaces
Aug 29, 2023
Hey @oxcened thank you so much for your contribution! @JReinhold could you check it out once you have time? Thanks! It might take some time as we are quite busy, we really appreciate your efforts and patience <3 |
ndelangen
changed the title
Controls: Fix select and multiselect controls not working when value contains multiple spaces
Controls: Fix select and multiselect controls when value contains multiple spaces
Sep 19, 2023
ndelangen
changed the title
Controls: Fix select and multiselect controls when value contains multiple spaces
Controls: Fix select / multiselect when value contains multiple spaces
Sep 19, 2023
ndelangen
approved these changes
Sep 19, 2023
ndelangen
approved these changes
Oct 9, 2023
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17051.
Analysis
Select and multiselect controls won’t work when selecting an option with multiple spaces, causing the select to reset and the URL reference to be removed or added as "undefined", in the case of multiselect. This is due to the options not receiving the value prop. According to the HTML specs:
So HTML is involved, which is notoriously unreliable about multiple white spaces.
What I did
I've added the value to both the select and multiselect components.
How to test
yarn task --task sandbox --start-from auto --template react-vite/default-ts
./?path=/story/addons-controls-basics--undefined
.Or just run the E2E tests I've added.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]