docs: add information about @storybook/preview-api useArgs hook #22590
Conversation
jonniebigodes
added
documentation
patch:yes
|
Alright. This is ready. Updated the code to avoid the eslint and storybook errors reported, with the minimal fix needed (disabling one line for eslint). I think this is the best that can be done until there is some help or answer on #22593 |
|
Aligned code block with answer in #22593 . This PR is good to go for review :) |
There was a problem hiding this comment.
@jonthenerd, thanks for taking the time to put together this pull request and improve the documentation. Appreciate it. I left one item for you to look into.
Let me know once you've addressed it and we'll take it from there.
Have a great week.
Stay safe
Provide example for those migrating from v6 to v7 and were previously using the @storybook/client-api useArgs hook
Removed remnant of template method. Shoudl be GTG now.
Removed unnecessary export
Made changes to code block to ensure that it will pass eslint rule `react-hooks/rules-of-hooks`
…int or storybook errors
There was a problem hiding this comment.
@jonthenerd left a couple of items for you to look at when you're able. Let me know once you've addressed them and we'll take it from there. Sounds good?
kasperpeulen
removed
the
patch:yes
|
Working on this again. This is NOT ready for review yet. Will update when it is. |
|
@jonthenerd no problem whatsoever; ping me when you're ready, and I'll be more than glad to take another look at it. Sounds good? |
|
@jonniebigodes think it's ready to go. Give it a whirl please :) FYI - I'm used to leaving the comment threads unresolved and letting the original reviewer resolve them to ensure they've been addressed as desired. Please resolve them if you think they are, or let me know to resolve them and I will. Everybody's different. |
|
@jonniebigodes this is ready for re-review |
|
@jonniebigodes , perhaps you're on vacation? @akashchouhan16 is there someone else who should review? |
|
@jonthenerd sorry for the radio silence. I was away for some time off, but I haven't forgotten about this. If you don't mind, I'll check it on Monday and if nothing arises, I'll gladly merge it. Hope you have a fantastic weekend. Stay safe |
Sounds good @jonniebigodes . Hope your time off was restful. |
There was a problem hiding this comment.
@jonthenerd, as promised, I've checked the pull request, and all is good on my end. Once again, thanks for taking the time to help us improve the documentation with this fantastic contribution. Appreciate it 🙏 !
I'll get it in once the checklist clears.
Hope you have a fantastic week.
Stay safe
Provide example for those migrating from v6 to v7 and were previously using the @storybook/client-api useArgs hook
Deals with (but likely isn't 100% relevant to) #12006
What I did
Added documentation to the seemingly relevant place with information about how to use the useArgs hook from within a story
How to test
N/A these are docs. However, it would be best to test this within an actual component to ensure the docs are right. I have within my own v7 storybook.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]