Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Create @storybook/test package based on vitest #23888

Closed
wants to merge 33 commits into from

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Aug 18, 2023

Closes #23870

What I did

See the issue

How to test

I added some more unit tests, but this needs some more tests before being merged.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This pull request has been released as version 0.0.0-pr-23888-sha-2b9981a9. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-23888-sha-2b9981a9
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/test-package
Commit 2b9981a9
Datetime Fri Oct 6 08:48:03 UTC 2023 (1696582083)
Workflow run 6429498489

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23888

@socket-security
Copy link

socket-security bot commented Aug 18, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@vitest/spy 0.34.7 None +2 42.5 kB oreanno
@types/jest 29.5.5 None +0 79.9 kB types
@vitest/expect 0.34.7 None +22 2.23 MB oreanno
chai 4.3.10 environment +12 1.01 MB keithamus

@socket-security
Copy link

socket-security bot commented Aug 18, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author pathval 1.1.1
New author check-error 1.0.3

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@kasperpeulen kasperpeulen marked this pull request as ready for review August 25, 2023 14:13
@kasperpeulen kasperpeulen changed the title Test: Create @storybook/test package Test: Create @storybook/test package based on vitest Aug 25, 2023
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/5976969367

@IanVS IanVS self-requested a review August 28, 2023 14:08
@ndelangen ndelangen changed the title Test: Create @storybook/test package based on vitest Test: Create @storybook/test package based on vitest Sep 19, 2023
@ndelangen ndelangen assigned kasperpeulen and unassigned yannbf and ndelangen Sep 19, 2023
@ndelangen
Copy link
Member

@kasperpeulen are you going to fix up this PR?

@ndelangen ndelangen marked this pull request as draft September 21, 2023 15:04
@kasperpeulen kasperpeulen marked this pull request as ready for review September 22, 2023 14:48
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6278018264

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6278069381

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6284078738

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6389798839

@yannbf yannbf mentioned this pull request Oct 3, 2023
8 tasks
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6405613056

@kasperpeulen kasperpeulen force-pushed the kasper/test-package branch 3 times, most recently from 7ce037d to 19150f2 Compare October 5, 2023 10:30
@kasperpeulen kasperpeulen added the ci:merged Run the CI jobs that normally run when merged. label Oct 5, 2023
@kasperpeulen
Copy link
Contributor Author

Superseded by:
#24392

@kasperpeulen kasperpeulen deleted the kasper/test-package branch July 3, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create @storybook/test
5 participants