-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manager: Update store.settings.lastTrackedStoryId
#24115
Merged
JReinhold
merged 6 commits into
storybookjs:next
from
rashidshamloo:bugfix-23723-canvas-link-shows-default-story-on-mobile
Oct 24, 2023
Merged
Manager: Update store.settings.lastTrackedStoryId
#24115
JReinhold
merged 6 commits into
storybookjs:next
from
rashidshamloo:bugfix-23723-canvas-link-shows-default-story-on-mobile
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lectStory() to enable keeping the current story active when navigating between sidebar and canvas on mobile
rashidshamloo
requested review from
ndelangen,
valentinpalkovic and
kasperpeulen
as code owners
September 8, 2023 22:54
ndelangen
approved these changes
Sep 19, 2023
@JReinhold OI'll leave this with you to decide: |
ndelangen
changed the title
fix: added code to update store.settings.lastTrackedStoryId in api.se…
Manager: Update Sep 19, 2023
store.settings.lastTrackedStoryId
JReinhold
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🙏
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23723
What I did
In
/code/ui/manager/src/components/layout/mobile.ts
when navigating between SideBar (handleSideBarClick()
) and Canvas (handleCanvasClick()
),api.retrieveSelection()
is used to get the current story id and if the returned id is falsy, the first story is selected as the current story.api.retrieveSelection()
returnsstore.getState().settings.lastTrackedStoryId
, however, thislastTrackedStoryId
is not set anywhere in the code, causing the returned value to always benull
and thus when switching between SideBar and Canvas, always the first story is displayed.When a story link is clicked on the SideBar, the
api.selectStory()
is called with the story id.To fix the issue, I have updated the
code/lib/manager-api/src/modules/stories.ts
file and added the code to update thestore.settings.lastTrackedStoryId
with the current story id whenapi.selectStory()
is called.I have also added a test for this behavior to the
code/lib/manager-api/src/tests/stories.test.ts
file.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>