Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add bottom navigation on mobile #24228

Merged
merged 31 commits into from
Sep 21, 2023
Merged

UI: Add bottom navigation on mobile #24228

merged 31 commits into from
Sep 21, 2023

Conversation

cdedreuille
Copy link
Contributor

@cdedreuille cdedreuille commented Sep 19, 2023

Closes #24221
Closes #24222
Closes #24216
Closes #23723

What I did

This PR is adding all the new mobile navigation and updating a few patterns to make sure actions are working on mobile as expected. The mobile navigation is consisting of 2 main drawers, one on the left for the global navigation, and one on the right for addons.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  • Run Storybook locally with yarn storybook:ui
  • Reduce your window below 600px
  • You should now see the mobile navigation

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/react-transition-group 4.4.6 None +0 18.9 kB types
react-transition-group 4.4.5 environment +2 497 kB eps1lon

🚮 Removed packages: @preact/[email protected], [email protected], [email protected]

@cdedreuille cdedreuille added maintenance User-facing maintenance tasks ci:normal labels Sep 19, 2023
@cdedreuille cdedreuille self-assigned this Sep 19, 2023
Base automatically changed from charles-mobile-1 to new-layout September 19, 2023 15:30
@cdedreuille cdedreuille changed the title UI: Add mobile drawers UI: Add bottom navigation on mobile Sep 19, 2023
@cdedreuille cdedreuille marked this pull request as ready for review September 20, 2023 09:41
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, I've requested some changes and we want stories for all the new components if possible.

@JReinhold
Copy link
Contributor

I've made some adjustments, mainly hiding the fullscreen tool when in mobile viewport (doesn't make sense), and hiding the "open addon panel" button when in docs mode, since docs don't have panels.

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@JReinhold JReinhold merged commit 63ca44c into new-layout Sep 21, 2023
14 checks passed
@JReinhold JReinhold deleted the charles-mobile-2 branch September 21, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants