-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add bottom navigation on mobile #24228
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @preact/[email protected], [email protected], [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, I've requested some changes and we want stories for all the new components if possible.
code/ui/manager/src/components/mobile/navigation/MobileMenuDrawer.tsx
Outdated
Show resolved
Hide resolved
code/ui/manager/src/components/mobile/navigation/MobileNavigation.tsx
Outdated
Show resolved
Hide resolved
code/ui/manager/src/components/mobile/navigation/MobileNavigation.tsx
Outdated
Show resolved
Hide resolved
code/ui/manager/src/components/mobile/navigation/MobileNavigation.tsx
Outdated
Show resolved
Hide resolved
code/ui/manager/src/components/mobile/about/MobileAbout.stories.tsx
Outdated
Show resolved
Hide resolved
I've made some adjustments, mainly hiding the fullscreen tool when in mobile viewport (doesn't make sense), and hiding the "open addon panel" button when in docs mode, since docs don't have panels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Closes #24221
Closes #24222
Closes #24216
Closes #23723
What I did
This PR is adding all the new mobile navigation and updating a few patterns to make sure actions are working on mobile as expected. The mobile navigation is consisting of 2 main drawers, one on the left for the global navigation, and one on the right for addons.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn storybook:ui
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>