Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT USE, SEE #24271 INSTEAD #24251

Closed
wants to merge 133 commits into from
Closed

DO NOT USE, SEE #24271 INSTEAD #24251

wants to merge 133 commits into from

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Sep 21, 2023 •
edited
Loading

Replaced by #24271

ndelangen and others added 30 commits December 22, 2022 00:14
@ndelangen
making changes
ae1d7a1
@ndelangen
improvements
eafbdfb
@ndelangen
make zoom work nicer
0604499
@ndelangen
use proper mobile nav bar
44bbd4f
@ndelangen
Merge branch 'next' into norbert/panel-size
69f307b
@ndelangen
connect it up to global state
544bc47
@ndelangen
improvements
0773caf
@ndelangen
cleanup
c354cab
@ndelangen
fix react warning
f2bed35
@ndelangen
replace the old
83ac400
@ndelangen
Merge branch 'next' into norbert/panel-size
d534e08
@ndelangen
cleanup
5bad257
@ndelangen
rename part 1
7fdfd4c
@ndelangen
renames part 2
4e6ec72
@ndelangen
rename part 3
4671b08
@ndelangen
rename part 4
751398e
@ndelangen
set parameters for preview component
6ec8679
@ndelangen
remove viewports 900
6874797
@ndelangen
this doesn't seem to work, let's just drop it or now
f335da2
@ndelangen
rename & fix mobile not having background behind panel and sidebar
e968a55
@ndelangen
more renaming as requested
cb8401f
@ndelangen
changes according to review comments, remove immer
dc98ac6
@ndelangen
Merge branch 'next' into norbert/panel-size
ff89ba3
@ndelangen
make it a named export
8503c33
@ndelangen
rename files
b4cda79
@ndelangen
deal with renames, and change to named export
e55e071
@ndelangen
Merge branch 'next' into norbert/panel-size
2f6ef15
@jd-oconnor
renamed styles and improved vertical drag to be smoother
f38ab2a
@jd-oconnor
moved hook and refactored reducer
c85f29b
@jd-oconnor
smooth dragging
a7ae4e9
cdedreuille and others added 23 commits September 20, 2023 10:20
@cdedreuille
Improved upgradeBlock
3f5c5fb
@cdedreuille
Update About page to take the new upgrade block
07f423c
@cdedreuille
Update MobileAbout.tsx
faa5fb1
@cdedreuille
Fix issue when clicking on search
56feda8
@cdedreuille
Fix CI errors
7a105d2
@cdedreuille
Update Panel.tsx
5218bab
@cdedreuille
Move sidebar and panel outside of each components
d41bc20
@JReinhold
use context for layout states
82a98d8
@JReinhold
improve closing about page
65127d9
@JReinhold
add mobile stories
568215d
@JReinhold
cleanup
d599393
@JReinhold
disable mobile panel button in docs mode
1eec03b
@JReinhold
improve mobile stories
efa3aed
@JReinhold
viewport in mobile about
1fd83dd
@JReinhold
fix types
da1fbd5
@JReinhold
fix drag handles when existing mobile
c950a98
@JReinhold
fix about stories
ff336a1
@JReinhold
Merge branch 'next' of github.com:storybookjs/storybook into new-layout
9fc9b14
@JReinhold
Merge branch 'new-layout' of github.com:storybookjs/storybook into ch…
7bb3e8b 
…arles-mobile-2
@JReinhold
remove fullscreen button in mobile view
3ab7738
@JReinhold
fix bottom panel being able to go beyond the viewport
f1a276e
@JReinhold
Merge pull request #24228 from storybookjs/charles-mobile-2
63ca44c 
UI: Add bottom navigation on mobile
@JReinhold
use full story name + title in mobile navigation heading
8604570
@JReinhold JReinhold added the ci:merged Run the CI jobs that normally run when merged. label Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023 •
edited
Loading

Fails
🚫 PR is marked with "ci: do not merge" label.
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]
🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against bccb9eb

@JReinhold JReinhold changed the title Storybook v8.0.0 DO NOT USE, SEE #24271 INSTEAD Sep 22, 2023
@JReinhold JReinhold closed this Sep 22, 2023
@cdedreuille cdedreuille deleted the v8 branch September 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegach kylegach Awaiting requested review from kylegach kylegach will be requested when the pull request is marked ready for review kylegach is a code owner

@jonniebigodes jonniebigodes Awaiting requested review from jonniebigodes jonniebigodes will be requested when the pull request is marked ready for review jonniebigodes is a code owner

Assignees
No one assigned
Labels
ci: do not merge ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JReinhold @ndelangen @jd-oconnor @cdedreuille