Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix notifications not appearing in new layout #24281

Merged
merged 12 commits into from
Oct 31, 2023
Merged

UI: Fix notifications not appearing in new layout #24281

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
930b975
add Notifications to Layout
JReinhold Sep 22, 2023
49b599b
Fixes box shadow problem
cdedreuille Sep 26, 2023
534a635
Merge branch 'release-8-0' into fix-notifications-in-new-layout
cdedreuille Sep 26, 2023
b2a1b9e
Custom positioning of notiication
cdedreuille Oct 4, 2023
a56ddcc
Merge branch 'release-8-0' into fix-notifications-in-new-layout
cdedreuille Oct 18, 2023
c34f711
Merge branch 'release-8-0' into fix-notifications-in-new-layout
JReinhold Oct 26, 2023
86dedf2
Merge branch 'release-8-0' into fix-notifications-in-new-layout
cdedreuille Oct 30, 2023
cec1b83
Improved Notifications to have a fixed placement in CSS
cdedreuille Oct 30, 2023
46bfc2a
Update NotificationList.tsx
cdedreuille Oct 31, 2023
1ecac7e
Fix maxHeight on scroll + improve stories
cdedreuille Oct 31, 2023
b744fe8
Update NotificationList.stories.tsx
cdedreuille Oct 31, 2023
9598dc3
Improved stories
cdedreuille Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions code/ui/manager/src/components/layout/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useDragging } from './useDragging';
import { MobileNavigation } from '../mobile/navigation/MobileNavigation';
import { MEDIA_DESKTOP_BREAKPOINT } from '../../constants';
import { useLayout } from './LayoutProvider';
import { Notifications } from '../../container/Notifications';

interface InternalLayoutState {
isDragging: boolean;
Expand Down Expand Up @@ -142,6 +143,7 @@ export const Layout = ({ managerLayoutState, setManagerLayoutState, ...slots }:
isDragging={isDragging}
viewMode={managerLayoutState.viewMode}
>
<Notifications />
{showPages && <PagesContainer>{slots.slotPages}</PagesContainer>}
<ContentContainer>{slots.slotMain}</ContentContainer>
{isDesktop && (
Expand Down
266 changes: 0 additions & 266 deletions code/ui/manager/src/components/notifications/NotificationItem.stories.jsx
View file
Open in desktop

This file was deleted.

Loading