Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Build: Cancel when the PR count is 0" #24293

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Revert "Build: Cancel when the PR count is 0" #24293

merged 1 commit into from
Sep 24, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 24, 2023

Reverts #24274

@shilman shilman merged commit 43b7366 into next Sep 24, 2023
5 checks passed
@shilman shilman deleted the revert-24274-norbert/gh-pr-creation-bug-fixed branch September 24, 2023 18:12
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2023 •
edited
Loading

Fails
🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

Generated by 🚫 dangerJS against 12be604

@github-actions github-actions bot mentioned this pull request Sep 24, 2023
Merged
20 tasks
@ndelangen
Copy link
Member

@JReinhold Let's chat about this one later this week?

@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Oct 3, 2023
@JReinhold
Copy link
Contributor

@ndelangen I re-added it to my bigger release tooling PR #24106 . The problem was that the code was never merged to main, which it expected, causing it to crash. I added a secondary check that just makes it work as usual until it's merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold Awaiting requested review from JReinhold

@ndelangen ndelangen Awaiting requested review from ndelangen

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

@yannbf yannbf Awaiting requested review from yannbf

@vanessayuenn vanessayuenn Awaiting requested review from vanessayuenn

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @ndelangen @JReinhold