Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBK-132 - The contrast ratio between foreground and background color of “RAW” button 3.6:1 which is less than required ratio 4.5:1. #24343

Closed
wants to merge 1 commit into from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Oct 2, 2023

Issue: #22473

What I did

  • change the text of RAW button to default text

How to test

Demo

Before

Screenshot 2023-10-03 at 19 48 50

After

Screenshot 2023-10-03 at 19 53 32

@gitstart gitstart marked this pull request as ready for review October 2, 2023 14:04
@valentinpalkovic
Copy link
Contributor

cc @cdedreuille

@cdedreuille
Copy link
Contributor

The images doesn't seem to work. Can you update that @gitstart?

@cdedreuille
Copy link
Contributor

cdedreuille commented Nov 7, 2023

Thanks a lot for contributing to Storybook. I believe this issue was already resolved in this PR #24525. We fixed the color at the source in the theme making it available everywhere. I'll close this PR for now but if there's anything I missed, please add a comment or reopen it.

@cdedreuille cdedreuille closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants